Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run benchmarks in quick mode in CI #119

Merged
merged 7 commits into from
May 15, 2024
Merged

Conversation

astrofrog
Copy link
Member

We should make sure that there are no syntax or code issues and that the benchmarks run with the latest version of astropy, otherwise we risk introducing broken benchmarks here and breaking the astropy CI subsequently.

@astrofrog
Copy link
Member Author

I've expanded the test suite to do what we used to do on Travis which is to test against a bunch of stable releases of astropy as well as the developer version, since we need to make sure the benchmark suite can work with a range of versions in order to produce useful graphs.

@astrofrog astrofrog requested a review from pllim May 15, 2024 11:36
Copy link
Member

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can even consider replacing 61 with just stable so we don't have to come back and update this every release.

.github/workflows/main.yml Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
@astrofrog astrofrog requested a review from pllim May 15, 2024 12:58
Copy link
Member

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@pllim pllim merged commit a26935f into astropy:main May 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants