-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run benchmarks in quick mode in CI #119
Conversation
I've expanded the test suite to do what we used to do on Travis which is to test against a bunch of stable releases of astropy as well as the developer version, since we need to make sure the benchmark suite can work with a range of versions in order to produce useful graphs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can even consider replacing 61
with just stable
so we don't have to come back and update this every release.
Co-authored-by: P. L. Lim <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
We should make sure that there are no syntax or code issues and that the benchmarks run with the latest version of astropy, otherwise we risk introducing broken benchmarks here and breaking the astropy CI subsequently.